Consistent with treating Ctor Call as Struct in liveness analysis #139782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
jieyouxu
added
L-unreachable_code
wesleywiser
approved these changes
Apr 16, 2025
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#138632 (Stabilize `cfg_boolean_literals`) - rust-lang#139416 (unstable book; document `macro_metavar_expr_concat`) - rust-lang#139782 (Consistent with treating Ctor Call as Struct in liveness analysis) - rust-lang#139885 (document RUSTC_BOOTSTRAP, RUSTC_OVERRIDE_VERSION_STRING, and -Z allow-features in the unstable book) - rust-lang#139904 (Explicitly annotate edition for `unpretty=expanded` and `unpretty=hir` tests) - rust-lang#139932 (transmutability: Refactor tests for simplicity) - rust-lang#139944 (Move eager translation to a method on Diag) - rust-lang#139948 (git: ignore `60600a6fa403216bfd66e04f948b1822f6450af7` for blame purposes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2025
Rollup merge of rust-lang#139782 - xizheyin:issue-139627, r=wesleywiser Consistent with treating Ctor Call as Struct in liveness analysis Fixes rust-lang#139627 When `ExprKind::Call` is a `Ctor`, skips the checking of `expr` and only checks the arguments, thus being consistent with `ExprKind::Struct`. r? compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139627
When
ExprKind::Callis aCtor, skips the checking ofexprand only checks the arguments, thus being consistent withExprKind::Struct.r? compiler